This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
js-git-ipld <-> pando library #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix promise
corydickson
commented
Apr 30, 2019
| } | ||
| } | ||
|
|
||
| public async fetchModifiedTree(): Promise<void> { |
There was a problem hiding this comment.
I came upon this solution given that we couldn't traverse the tree inside the constructor
corydickson
commented
Apr 30, 2019
| @@ -156,3 +141,25 @@ const fetchFilesFromTree = (hash, path) => { | |||
| }) | |||
| }) | |||
| } | |||
|
|
|||
| const fetchOrderedHistory = async (hash, formerHistory) => { | |||
There was a problem hiding this comment.
In the final version of this PR, we'll deprecate all of these helper functions in this file and import them from pando.ts
osarrouy
reviewed
Apr 30, 2019
There was a problem hiding this comment.
Hey ! I added a couple of comment. Also I think the best would be to:
- split this lib into its own package. We may need to use it in other places [especially in the GraphProtocol reducer if we come up with one]
- Write test to make sure of the consistency of the lib. The best would be extract a known IPLD commit history build with pando and, in the test, push it to IPFS and then try to fetch it again / update it. Otherwise i think it will be super tricky to test the behaviour of the lib each time we update it.
| author: IAuthorOrCommitter | ||
| committer: IAuthorOrCommitter | ||
| message: string | ||
| parents: ITree[] | null |
There was a problem hiding this comment.
Isn't it supposed to be : parents: ILinkedCommitData[] ?
|
Closing for now since we need to figure out an answer to #50 before ... Will re-open later if needed ... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for some feedback on this approach before I deprecate IPLD functions inside of
script.jsTodo:
Commitclass back into IPLD format.Resolves #50